Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bitcode iOS SDK #9

Closed
wants to merge 1 commit into from
Closed

Add support for bitcode iOS SDK #9

wants to merge 1 commit into from

Conversation

petergam
Copy link

This is a request for you to enabled bitcode for the iOS SDK. I realise that this way of requesting it is a little odd but I thought it was worth a shot!

Bitcode is an intermediate representation of a compiled program. Apps you upload to iTunes Connect that contain bitcode will be compiled and linked on the App Store. Including bitcode will allow Apple to re-optimize your app binary in the future without the need to submit a new version of your app to the store.

Note: For iOS apps, bitcode is the default, but optional. If you provide bitcode, all apps and frameworks in the app bundle need to include bitcode. For watchOS apps, bitcode is required

Apps using your framework must currently disable bitcode since MobilePay-AppSwitch-SDK has it disabled. Apple will most likely require bitcode in the future so enabling it is the right choice going forward.

@PelleRavn
Copy link

I asked about this back in december. The answer at that time was that a part of the MobilePay SDK is the OpenSSL SDK, and it doesn't support Bitcode. I'm not aware if that has changed in OpenSSL in the last 6 months, but I think the MobilePay SDK team want to support Bitcode if they could - so guess it will come when it's all their dependencies supports Bitcode.

@petergam
Copy link
Author

Thanks for providing that information @PelleRavn

Compiling OpenSSL with bitcode enabled should be supported, I dont know which script the MobilePay team uses to compile OpenSSL but if there are using https://github.com/x2on/OpenSSL-for-iPhone it should work out of the box.

I really hope the team will consider looking into this again.

@petergam
Copy link
Author

Any update on this? Maybe from @duytv?

@sn3ek
Copy link

sn3ek commented Oct 23, 2017

Please provide a new build with bitcode enabled.

@simonbs
Copy link

simonbs commented Jun 25, 2018

Please provide a version of your SDK with bitcode enabled. Currently all apps that support MobilePay will have to disable bitcode which is unheard of.

@bigfishtoddslivewire
Copy link

I'll see if it works for me. Let's hope

@christiankm
Copy link

christiankm commented Jul 31, 2018 •
edited
Loading

Thanks for your comments. We have added support for Bitcode in version 1.8.1.
Feel free to open a PR for any wishes or send me a DM. Alternatively please send your wishes to [email protected].

@simonbs
Copy link

simonbs commented Mar 20, 2020

@christiankm It looks like the latest version (2.2.0) doesn't have bitcode enabled. Is it intentional that it was disabled again?

@christiankm
Copy link

Hi @simonbs,
Sorry for not being your message. I will ask the responsible people about this :)

@christiankm
Copy link

christiankm commented May 18, 2020 •
edited
Loading

@simonbs It seems that Bitcode is enabled. What errors are you seeing?
If installing via CocoaPods, it should help if you can remove any -Objc linker flags in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petergam @PelleRavn @sn3ek @simonbs @bigfishtoddslivewire @christiankm